Conversation
nperraud
approved these changes
May 27, 2020
Collaborator
nperraud
left a comment
nperraud
left a comment
There was a problem hiding this comment.
I do not see anything to complain about here.
Collaborator
|
Let us merge once the tests are passing. Probably a rebase should do. |
Collaborator
Author
|
Test fails because scikit-image replaced their camera(man) image from version 0.17.0 (used with python 3.6) to 0.18.0 (used with python 3.7-3.9). Refs: scikit-image/scikit-image#3927, scikit-image/scikit-image#4913, scikit-image/scikit-image#4914. We can either use another image, or wait until we drop python 3.6 (I'd say right after we make a release) to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this info is also shown in plots, those are not seen on text interfaces.